windows was deprecated in iOS 15: Use UIWindowScene.windows instead #8077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamgabrielma
added
type: enhancement
Collaborator
You can test the changes from this Pull Request by:
|
Ecarrion
approved these changes
Nov 10, 2022
Contributor
Ecarrion
left a comment
Ecarrion
left a comment
There was a problem hiding this comment.
A bit more complex, but if it works it works! Thanks for handling this warning! 🙇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By updating the minimum release version to iOS 15 recently, we've seen some deprecation warnings. This PR fixes the case for
'windows' was deprecated in iOS 15.0: Use UIWindowScene.windows on a relevant window scene instead.Changes
Rather than getting the first window through the
UIApplication.windowsshared instance, we get the window through its connected scenes, by filtering down the first one that is of typeUIWindowScene. With this we still get the same behavior, and we remove the deprecation warning.Testing instructions
I based my own testing on the cases of the original PR, in this case, as this pattern allows us to set custom safe areas for the focus window, we can test the Simple Payments flow with big fonts and on landscape and see that everything still looks correct.
Screenshots